Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-unreachable: allow type alias after function return #1183

Merged
merged 2 commits into from
Apr 29, 2016
Merged

no-unreachable: allow type alias after function return #1183

merged 2 commits into from
Apr 29, 2016

Conversation

YuichiNukiyama
Copy link
Contributor

fix #564

@adidahiya
Copy link
Contributor

thanks for the PR!

lgtm 👍

jkillian
jkillian reviewed Apr 29, 2016
View reviewed changes
src/rules/noUnreachableRule.ts
@@ -99,4 +100,8 @@ class NoUnreachableWalker extends Lint.RuleWalker {
super.visitThrowStatement(node);
this.hasReturned = true;
}

public visitTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually need to add these lines - visitNode gets called on all nodes by default

@jkillian
Copy link
Contributor

Hi @YuichiNukiyama, thanks for the PR, just a couple tweaks and then we can merge this!

@YuichiNukiyama
Copy link
Contributor Author

Thank you for your review. I did it.

@jkillian
Copy link
Contributor

Looks great, thanks!

@jkillian jkillian merged commit 97a3a98 into palantir:master Apr 29, 2016
@YuichiNukiyama YuichiNukiyama deleted the fix564 branch April 29, 2016 21:20
tomduncalf pushed a commit to tomduncalf/tslint that referenced this pull request Jun 14, 2016
@YuichiNukiyama @tomduncalf
no-unreachable: allow type alias after function return (palantir#1183)
b0e88a5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jkillian jkillian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect unreachable code error for type alias after function return
3 participants
@YuichiNukiyama @adidahiya @jkillian