Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Bump NPM dependencies and switch to ESLint #1221

Merged
merged 5 commits into from
May 10, 2016
Merged

Bump NPM dependencies and switch to ESLint #1221

merged 5 commits into from
May 10, 2016

Conversation

adidahiya
Copy link
Contributor

fixes #1220

@adidahiya adidahiya added this to the TSLint v3.10 milestone May 7, 2016
jkillian
jkillian reviewed May 7, 2016
View reviewed changes
package.json
@@ -22,21 +22,21 @@
"dependencies": {
"colors": "^1.1.2",
"diff": "^2.2.1",
"findup-sync": "~0.3.0",
"glob": "^6.0.1",
"findup-sync": "~0.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noooo undo! (see #1108)

@jkillian
Copy link
Contributor

jkillian commented May 7, 2016

Also, build errors because of invalid peer dependencies :/

image

@adidahiya
Copy link
Contributor Author

yep, noticed the invalid peer deps... will try to investigate tomorrow

@jkillian
Copy link
Contributor

jkillian commented May 9, 2016 •
edited
Loading

Related: unindented/grunt-npm-command#7
I think that might solve the peerDependency issues

@adidahiya
Copy link
Contributor Author

I'd actually prefer to remove the grunt-npm-command dependency. It is a small package with very few users.

@jkillian
Copy link
Contributor

jkillian commented May 9, 2016

Sounds good, as long as things work correctly across platforms/CIs. Note #1172 which is the relevant discussion when it was added

@jkillian
Copy link
Contributor

grunt-npm-command released a new version to fix the peerDep error, so the build is passing now. I'm inclined to just let it stay for now, it's working well in our build.

@adidahiya adidahiya mentioned this pull request May 10, 2016
Closed
@adidahiya
Copy link
Contributor Author

meh, ok. filed follow-up #1235

@jkillian jkillian merged commit e4deab7 into master May 10, 2016
@jkillian jkillian deleted the ad/npm-deps branch May 10, 2016 15:13
tomduncalf pushed a commit to tomduncalf/tslint that referenced this pull request Jun 14, 2016
@adidahiya @tomduncalf
Bump NPM dependencies and switch to ESLint (palantir#1221)
5ef5e9f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: waiting for reviewer
Projects
None yet
Milestone
TSLint v3.10
Development

Successfully merging this pull request may close these issues.

Use ESLint instead of JSCS in our own build
2 participants
@adidahiya @jkillian