This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Check for newly introduced diagnostics before reporting failures (for unused import) #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @alexeagle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
See also discussion in the linked issue. TypeScript can fix this particular issue in the future, but tslint might still benefit from this capability in other cases. |
|
Ping! |
jkillian
approved these changes
Oct 28, 2016
| } | ||
|
|
||
| export function checkEdit(ls: ts.LanguageService, sf: ts.SourceFile, newText: string) { | ||
| if (ls.hasOwnProperty("editFile")) { |
There was a problem hiding this comment.
typeguard function would be nice here
| @@ -74,6 +81,9 @@ export function runTest(testDirectory: string, rulesDirectory?: string | string[ | |||
| return ts.createSourceFile(filenameToGet, fileText, compilerOptions.target); | |||
| } else if (filenameToGet === fileCompileName) { | |||
| return ts.createSourceFile(fileBasename, fileTextWithoutMarkup, compilerOptions.target, true); | |||
| } else if (fs.existsSync(path.resolve(path.dirname(fileToLint), filenameToGet))) { | |||
There was a problem hiding this comment.
just curious, what's this case for?
added 2 commits
November 23, 2016 17:20
# Conflicts: # src/language/rule/typedRule.ts # src/rules/preferForOfRule.ts # src/test.ts # src/tslintMulti.ts
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a program is available, verify that fixes for no-unused-variable don't introduce new diagnostics. If a fix breaks the program, don't report that failure at all.
This re-uses TypeScript to verify that our failures are legitimate, without having to re-implement the TS logic for whether an import is actually unused. This capability can be used in other rules as well, ensuring that accepting tslint fixes won't break type-checking.
The downside is that it makes the check slower, especially in a codebase with many unused imports, since each file must be checked (and those with spurious failures must have each unused import checked).
Fixes #1569