Build system enhancements

.gitignore

@@ -13,3 +13,6 @@ typings/.basedir.ts
 # vim swap files
 *.swo
 *.swp
+
+# grunt-ts, see See https://github.com/grunt-ts/grunt-ts/issues/77
+.baseDir.ts

appveyor.yml

@@ -7,12 +7,10 @@ environment:
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
-  - npm install -g grunt-cli
 
 test_script:
   - node --version
   - npm --version
-  - grunt --version
-  - grunt
+  - npm run verify
 
 build: off

circle.yml

@@ -5,6 +5,9 @@ general:
 dependencies:
   pre:
     - case $CIRCLE_NODE_INDEX in 0) nvm use 4.2 ;; 1) nvm use 5.7 ;; 2) nvm use 6.1 ;; esac
+test:
+  override:
+    - npm run verify
 deployment:
   npm-latest:
     # match semver tag (e.g. 3.12.7)

package.json

@@ -17,7 +17,23 @@
     "linter"
   ],
   "scripts": {
-    "test": "grunt"
+    "clean": "npm-run-all -p clean:core clean:test",
+    "clean:core": "rm -rf lib",
+    "clean:test": "rm -rf build && rm -rf test/config/node_modules",
+    "docs": "node scripts/buildDocs.js",
+    "compile": "npm-run-all -p compile:core compile:test -s compile:scripts",
+    "compile:core": "tsc -p src",
+    "compile:scripts": "tsc -p scripts",
+    "compile:test": "tsc -p test",
+    "lint": "npm-run-all -p lint:core lint:test",
+    "lint:core": "tslint src/**/*.ts",
+    "lint:test": "tslint test/**/*.ts -e test/**/*.test.ts",
+    "test": "npm-run-all test:pre -p test:bin test:mocha test:rules",
+    "test:pre": "cd ./test/config && npm install",
+    "test:bin": "./test/check-bin.sh &> /dev/null",
+    "test:mocha": "mocha --reporter spec --colors build/test/**/*Tests.js build/test/assert.js",
+    "test:rules": "node ./build/test/ruleTestRunner.js",
+    "verify": "npm-run-all clean compile lint test docs"
   },
   "dependencies": {
     "colors": "^1.1.2",
@@ -29,18 +45,22 @@
     "underscore.string": "^3.3.4"
   },
   "devDependencies": {
+    "@types/chai": "^3.4.34",
+    "@types/colors": "^0.6.33",
+    "@types/diff": "0.0.31",
+    "@types/findup-sync": "^0.3.29",
+    "@types/glob": "^5.0.30",
+    "@types/js-yaml": "^3.5.28",
+    "@types/mocha": "^2.2.32",
+    "@types/node": "^6.0.45",
+    "@types/optimist": "0.0.29",
+    "@types/resolve": "0.0.4",
+    "@types/underscore": "^1.7.33",
+    "@types/underscore.string": "0.0.30",
     "chai": "^3.0.0",
-    "grunt": "^1.0.1",
-    "grunt-cli": "^1.2.0",
-    "grunt-contrib-clean": "^1.0.0",
-    "grunt-eslint": "^19.0.0",
-    "grunt-mocha-test": "^0.13.2",
-    "grunt-npm-command": "^0.1.2",
-    "grunt-run": "~0.6.0",
-    "grunt-ts": "^5.5.1",
-    "grunt-tslint": "latest",
     "js-yaml": "^3.6.1",
     "mocha": "^3.1.0",
+    "npm-run-all": "^3.1.0",
     "tslint": "latest",
     "tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative",
     "typescript": "2.0.3"

scripts/buildDocs.ts

@@ -76,6 +76,8 @@ interface IDocumentation {
 
 const DOCS_DIR = "../docs";
 
+process.chdir("./scripts");
+
 /**
  * Documentation definition for rule modules.
  */

scripts/tsconfig.json

@@ -1,35 +1,12 @@
 {
-    "version": "1.8.0",
+    "version": "2.0.3",
     "compilerOptions": {
         "module": "commonjs",
         "noImplicitAny": true,
+        "noUnusedParameters": true,
+        "noUnusedLocals": true,
         "declaration": false,
         "sourceMap": false,
-        "target": "es5",
-        "outDir": "."
-    },
-    "atom": {
-        "rewriteTsconfig": false
-    },
-    "filesGlob": [
-        "../custom-typings/**/*.d.ts",
-        "../typings/**/*.d.ts",
-        "./*.ts"
-    ],
-    "files": [
-        "../custom-typings/object.d.ts",
-        "../custom-typings/resolve.d.ts",
-        "../typings/colors/colors.d.ts",
-        "../typings/diff/diff.d.ts",
-        "../typings/findup-sync/findup-sync.d.ts",
-        "../typings/glob/glob.d.ts",
-        "../typings/js-yaml/js-yaml.d.ts",
-        "../typings/minimatch/minimatch.d.ts",
-        "../typings/node/node.d.ts",
-        "../typings/optimist/optimist.d.ts",
-        "../typings/tsd.d.ts",
-        "../typings/underscore.string/underscore.string.d.ts",
-        "../typings/underscore/underscore.d.ts",
-        "buildDocs.ts"
-    ]
-}
+        "target": "es5"
+    }
+}

src/language/rule/typedRule.ts

@@ -21,7 +21,7 @@ import {AbstractRule} from "./abstractRule";
 import {RuleFailure} from "./rule";
 
 export abstract class TypedRule extends AbstractRule {
-    public apply(sourceFile: ts.SourceFile): RuleFailure[] {
+    public apply(_sourceFile: ts.SourceFile): RuleFailure[] {
         // if no program is given to the linter, throw an error
         throw new Error(`${this.getOptions().ruleName} requires type checking`);
     }

src/language/utils.ts

@@ -29,7 +29,7 @@ export function getSourceFile(fileName: string, source: string): ts.SourceFile {
         getCanonicalFileName: (filename: string) => filename,
         getCurrentDirectory: () => "",
         getDefaultLibFileName: () => "lib.d.ts",
-        getDirectories: (path: string) => [],
+        getDirectories: (_path: string) => [],
         getNewLine: () => "\n",
         getSourceFile: (filenameToGet: string) => {
             if (filenameToGet === normalizedName) {

src/rules/memberOrderingRule.ts

@@ -275,11 +275,11 @@ export class MemberOrderingWalker extends Lint.RuleWalker {
         super.visitPropertySignature(node);
     }
 
-    public visitTypeLiteral(node: ts.TypeLiteralNode) {
+    public visitTypeLiteral(_node: ts.TypeLiteralNode) {
         // don't call super from here -- we want to skip the property declarations in type literals
     }
 
-    public visitObjectLiteralExpression(node: ts.ObjectLiteralExpression) {
+    public visitObjectLiteralExpression(_node: ts.ObjectLiteralExpression) {
         // again, don't call super here - object literals can have methods,
         // and we don't wan't to check these
     }
@@ -298,7 +298,7 @@ export class MemberOrderingWalker extends Lint.RuleWalker {
             const failure = this.createFailure(
                 node.getStart(),
                 node.getWidth(),
-                `Declaration of ${toString(currentMember)} not allowed to appear after declaration of ${toString(this.previousMember)}`
+                `Declaration of ${toString(currentMember)} not allowed to appear after declaration of ${toString(this.previousMember)}`,
             );
             this.addFailure(failure);
         }
@@ -367,7 +367,7 @@ export class MemberOrderingWalker extends Lint.RuleWalker {
                     this.addFailure(this.createFailure(
                         node.getStart(),
                         node.getWidth(),
-                        errorLine1
+                        errorLine1,
                     ));
                 } else {
                     // keep track of last good node

src/rules/noDuplicateVariableRule.ts

@@ -71,11 +71,11 @@ class NoDuplicateVariableWalker extends Lint.BlockScopeAwareRuleWalker<{}, Scope
         this.visitBlock(node.block);
     }
 
-    public visitMethodSignature(node: ts.SignatureDeclaration) {
+    public visitMethodSignature(_node: ts.SignatureDeclaration) {
         // don't call super, we don't want to walk method signatures either
     }
 
-    public visitTypeLiteral(node: ts.TypeLiteralNode) {
+    public visitTypeLiteral(_node: ts.TypeLiteralNode) {
         // don't call super, we don't want to walk the inside of type nodes
     }