This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
More intuitive configuration composition #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkillian
previously requested changes
Oct 12, 2016
| @@ -2,6 +2,7 @@ | |||
| "rulesDirectory": ["../files/custom-rules-2", "../files/custom-rules/"], | |||
| "rules": { | |||
| "always-fail": true, | |||
| "no-fail": true | |||
| "no-fail": true, | |||
| "rule-two": true | |||
There was a problem hiding this comment.
what was this for? It seems to break the tests because there is no rule-two in existence for this test
There was a problem hiding this comment.
removed this. Did was not hitting a unique test case
There was a problem hiding this comment.
actually this is needed to override another config
adidahiya
added
PR: waiting for author
Current Sprint
and removed
Status: Work In Progress
labels
nchen63
reviewed
Nov 3, 2016
| combinedConfig.rules[name] = config.rules[name]; | ||
| // next config source overwrites the target config object | ||
| for (const name of Object.keys(objectify(nextConfigSource.rules))) { | ||
| combinedConfig.rules[name] = nextConfigSource.rules[name]; |
There was a problem hiding this comment.
please pick up changes from master and update combinedConfig.jsRules
|
should probably get this in for 4.0 since it's breaking |
nchen63
force-pushed
the
ad/extends-order
branch
2 times, most recently
from
dfc718d to
06f3521
Compare
nchen63
force-pushed
the
ad/extends-order
branch
from
06f3521 to
49d8437
Compare
added 2 commits
November 10, 2016 15:24
… rule Removed the failing test case in executableTests. The test doesn't add much
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1503.