This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
New Rule: no-non-null-assertion #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Feb 21, 2017
src/rules/noNonNullAssertionRule.ts
Outdated
| @@ -0,0 +1,47 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2013 Palantir Technologies, Inc. | |||
src/rules/noNonNullAssertionRule.ts
Outdated
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "no-non-null-assertion", | ||
| description: "Disallows non null assertions.", |
There was a problem hiding this comment.
Would be nice if you also add rationale to describe why this rule is useful.
|
@ajafff Thank you for review! |
arusakov
force-pushed
the
no-non-null-assertion
branch
from
8f6c676
to
a433216
Compare
adidahiya
approved these changes
Feb 21, 2017
|
@arusakov thanks! |
|
awesome, can we get a new tslint release with this, please @nchen63? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1444