This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Un-deprecate noUnusedVariable. #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in feedback on palantir#1481 and palantir#1617, for many users `--noUnusedParameters` and `--noUnusedLocals` do not work as a replacement for `noUnusedVariable`. This change de-deprecates the rule and documents the alternative compiler flags (and why they might not work for users) in the description. Fixes palantir#1617.
|
Ok, after seeing all the community feedback around this, I'm inclined to agree and un-deprecate the rule. |
adidahiya
approved these changes
Feb 27, 2017
|
So, how to actually enable this rule? |
This was referenced Jul 17, 2018
5 tasks
|
Per #3919, apparently this is deprecated again |
|
locking in favor of discussion in #4100 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in feedback on #1481 and #1617, for many users
--noUnusedParametersand--noUnusedLocalsdo not work as a replacement fornoUnusedVariable. This change de-deprecates the rule and documents the alternative compiler flags (and why they might not work for users) in the description.Fixes #1617.
This is a proposal, please discuss and feel free to reject :-)
PR checklist