This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
file-header fix for single-line comments #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file-header rule was not correctly parsing single-line comments. Therefore the regex was not working. That is now fixed.
|
Thanks for your interest in palantir/tslint, @battmanz! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
battmanz
commented
Mar 8, 2017
| @@ -4,9 +4,9 @@ | |||
| */ | |||
|
|
|||
| export class A { | |||
| public x = 1; | |||
There was a problem hiding this comment.
Since this is supposed to be a .js file test, I removed the visibility modifiers.
battmanz
commented
Mar 8, 2017
| @@ -1 +1,2 @@ | |||
| // empty. | |||
There was a problem hiding this comment.
Previously this file had just a single-line comment. That case is now covered by both the good-single-line and bad-single-line tests. I have modified this file to truly be empty.
ajafff
approved these changes
Mar 9, 2017
adidahiya
approved these changes
Mar 9, 2017
|
thanks @battmanz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file-header rule was not correctly parsing single-line comments. Therefore the regex was not working. That is now fixed.
PR checklist
Overview of change:
I fixed the
commentRegexpso that it will correctly parse single-line comments. It was an easy fix. I simply removed a?.Is there anything you'd like reviewers to focus on?
Please make sure I made the correct decision with the tests inside the
emptydirectory.CHANGELOG.md entry:
[bugfix]
file-header-rulenow handles single-line comments correctly