Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix for rest parameters in unified-signatures #2342

Merged
merged 4 commits into from
Mar 14, 2017
Merged

Fix for rest parameters in unified-signatures #2342

merged 4 commits into from
Mar 14, 2017

Commits on Mar 14, 2017

  1. Test case for issue #2338 

    `unified-signatues` erroneously claims overloads can be combined
    @sbj42
    sbj42 committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    09b4d02 View commit details
    Browse the repository at this point in the history

  2. Fix for issue #2338 

    Have `signaturesDifferByOptionalOrRestParameter()` use `parametersAreEqual()` to test the non-extra parameters.
    @sbj42
    sbj42 committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    61bf543 View commit details
    Browse the repository at this point in the history

  3. Better fix, don't consider questionToken 

    This focuses the fix on `dotDotDotToken`, which if present can only be the final token of the shorter signature.  The previous fix also considered `questionToken`, which made a different case pass when it should have failed.
    @sbj42
    sbj42 committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    8c011c3 View commit details
    Browse the repository at this point in the history

  4. Braces around if, newline at end of test file

    @sbj42
    sbj42 committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    7ae1a07 View commit details
    Browse the repository at this point in the history