This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add 'encoding' rule #2368
Merged
Add 'encoding' rule #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
suggested changes
Apr 29, 2017
src/test.ts
Outdated
| @@ -25,6 +25,7 @@ import * as ts from "typescript"; | |||
|
|
|||
| import {Fix} from "./language/rule/rule"; | |||
| import * as Linter from "./linter"; | |||
| import {readBufferWithDetectedEncoding} from "./rules/encodingRule"; | |||
nchen63
approved these changes
May 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added the
encodingrule, which checks each file's encoding.Is there anything you'd like reviewers to focus on?
This is a tricky one as it performs additional I/O, synchronously. It only reads 3 bytes but there may be lag.
The test runner had to be tweaked so that we would be reading the right file. I tested this rule out (using
npm link) in both regular and non-type-checked scenarios and it worked, but it's possible that something like gulp-tslint could break with this.