Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Refactor linebreak-style and add fixer #2394

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Refactor linebreak-style and add fixer #2394

merged 2 commits into from
Mar 24, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Mar 23, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

[new-fixer] linebreak-style
The rule checks the line ending directly in the source text instead of using a scanner. That way we also find failures inside multiline comments and template strings.

[new-fixer] `linebreak-style`
The rule checks the line ending directly in the source text instead of using a scanner. That way we also find failures inside multiline comments and template strings.
@@ -39,48 +39,34 @@ export class Rule extends Lint.Rules.AbstractRule {
optionExamples: [`[true, "${OPTION_LINEBREAK_STYLE_LF}"]`, `[true, "${OPTION_LINEBREAK_STYLE_CRLF}"]`],
type: "maintainability",
typescriptOnly: false,
hasFix: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@adidahiya adidahiya changed the title Refactor linebreak-style Refactor linebreak-style and add fixer Mar 24, 2017
@adidahiya adidahiya merged commit 2793e0f into palantir:master Mar 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants