one-line: Allow to specify "next-line"

[andy-hanson]

PR checklist

• Addresses an existing issue: #0000
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

Before, you would specify:

"one-line": [true, "check-catch", "check-else", "check-finally", "check-open-brace", "check-whitespace"]

"one-line": [true, {
	"catch": "next-line",
	"else": "next-line",
	"finally": "next-line",
	"open-brace": "same-line",
	"whitespace": true
}]

And get code like:

if (so) { // '{' on same line
	
}
// 'else' on next line
else {
	
}

Is there anything you'd like reviewers to focus on?

This is a breaking change to "one-line" as the options have changed.
We could instead create a new rule and deprecate "one-line". (The old name is less accurate now.) Or, we could deprecate the old options style but still handle it in parseOptions.

CHANGELOG.md entry:

TBD

[andy-hanson]

Added parsing for old-style options. Shouldn't be a breaking change any more.

[suchanlee]

@andy-hanson are you still working on this PR and relevant?

[andy-hanson]

Updated, seems to still work with no change. Note that there is an old-style-options test to test for backwards compatibility.

[giladgray]

@andy-hanson is there any way we can make this less breaking?

please update this branch so we can review it, or close it if no longer relevant. we will close this if we do not hear from you in two weeks.

[giladgray]

changing the option names is super breaking. do we have to do this?

[giladgray]

swap the order, reuse the constants.

const OPTION_SAME_LINE = "same-line";
const OPTION_NEXT_LINE = "next-line";
type BraceSetting = OPTION_SAME_LINE | OPTION_NEXT_LINE;

[johnwiseheart]

Closing due to age and inactivity. Feel free to re-open or create a new pull request if you decide to continue working on this.