This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
arrow-return-shorthand: Improve failure message when return expression is an object literal #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is an object literal
ajafff
reviewed
Apr 2, 2017
| function hasComments(node: ts.Node): boolean { | ||
| return ts.getTrailingCommentRanges(text, node.getEnd()) !== undefined; | ||
| } | ||
| function hasComments(node: ts.Node): boolean { |
There was a problem hiding this comment.
there is a function called hasCommentAfterPosition in src/language/utils.ts which does basically the same and will also handle leading trivia of the next token
adidahiya
approved these changes
Apr 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Changes the failure message to mention that parentheses are needed when the expression is an object literal.