This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rewrite and fix object-literal-key-quotes #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
reviewed
Apr 12, 2017
yarn.lock
Outdated
| version "1.4.0" | ||
| resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-1.4.0.tgz#84f8a83df9967d35bf1ff3aa48c7339593d64e19" | ||
|
|
||
| tsutils@^1.6.0: |
There was a problem hiding this comment.
sigh, let's try to de-dupe this entry again? not sure if it matters though
| @@ -6,8 +6,8 @@ const o = { | |||
| "hyphens-need-quotes": null, | |||
| [computed]: 456, | |||
| "123": "hello", // failure | |||
| "1e4": "something", // failure | |||
| ".123": "float", // failure | |||
| "10000": "something", // failure | |||
There was a problem hiding this comment.
how does the fix replacement know to expand 1e4 to 1000?
There was a problem hiding this comment.
1e4 is a numeric literal that is automatically expanded to 1000 by the javascript vm before stringifying. Fixing this to "1e4" would actually break the program.
> Object.keys({1e4: "foo"})
[ '10000' ]
> String(1e4)==="10000"
true
[bugfix] `object-literal-key-quotes`: does no longer require quotes for reserved words and property names containing digits [bugfix] `object-literal-key-quotes`: correctly stringify numbers when fixing
|
@adidahiya rebased and resolved merge conflicts |
adidahiya
approved these changes
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
object-literal-key-quotes: does no longer require quotes for property names containing digits[bugfix]
object-literal-key-quotes: correctly stringify numbers when fixingIs there anything you'd like reviewers to focus on?