This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
max-classes-per-file: Convert to function #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
max-classes-per-file
branch
from
4c048c7 to
8911f24
Compare
ajafff
reviewed
Apr 11, 2017
src/rules/maxClassesPerFileRule.ts
Outdated
| } | ||
|
|
||
| public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] { | ||
| return this.applyWithWalker(new MaxClassesPerFileWalker(sourceFile, this.getOptions())); | ||
| const argument = this.ruleArguments[0]; | ||
| const maxClasses = isNaN(argument) || (argument as number) < 0 ? 1 : argument; |
There was a problem hiding this comment.
There's a subtle bug here. The old implementation defaults 0 to 1. The new one doesn't.
You can also simplify this line.
const maxClasses = argument > 0 ? argument : 1;
adidahiya
approved these changes
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just a refactor. Also added a period to failure message.