Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Default type parameter of WalkContext and AbstractWalker to void #2600

Merged
merged 4 commits into from
Mar 24, 2019

Conversation

andy-hanson
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Most rules take no options, so it's simpler to not require a type parameter.

CHANGELOG.md entry:

[api] WalkContext and AbstractWalker type parameter defaults to void

@adidahiya
Copy link
Contributor

Doesn't this force custom rules to now use TS 2.3? I consider that a breaking change

@giladgray
Copy link

at this point i think a minimum TS dep of 2.3 is fine.

@andy-hanson can you please update this PR? or close it.

@andy-hanson
Copy link
Contributor Author

Had to commit with git commit --no-verify or else there was a huge number of changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants