Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add "format" rule category #2832

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Add "format" rule category #2832

merged 3 commits into from
Feb 23, 2019

Conversation

andy-hanson
Copy link
Contributor

PR checklist

Overview of change:

Adds a new RuleType and switches many rules to it.
The "format" category is for rules which would be handled by a formatter; these are rules which control the way an AST is represented as text.
I'm on the fence about whether to include "curly" here. It seems like a format-only rule, but I think a formatter would preserve whether you used curly braces around a one-line statement.

@giladgray
Copy link

@andy-hanson please update this branch so we can review it, or close it if not relevant.

@andy-hanson
Copy link
Contributor Author

Running git commit normally broke a bunch of stuff, had to redo with git commit --no-verify.

@JoshuaKGoldberg
Copy link
Contributor

Running git commit normally broke a bunch of stuff, had to redo with git commit --no-verify.

Should no longer be an issue for later updates after merging in from master now that #4214 and #4270 are in.

@adidahiya adidahiya added the Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier label Jan 17, 2019
@adidahiya adidahiya self-assigned this Jan 17, 2019
@adidahiya adidahiya added this to the 5.13.0 milestone Jan 17, 2019
@adidahiya
Copy link
Contributor

I will merge this but I would like to change the category name to "formatting", i'll do that in a separate PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants