Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-string-literal: Fix documentation #2875

Merged
merged 1 commit into from
Jun 5, 2017
Merged

no-string-literal: Fix documentation #2875

merged 1 commit into from
Jun 5, 2017

Conversation

andy-hanson
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Clarified the rule documentation.

  • The rule does nothing when a string literal is necessary, as in obj["foo-bar"].
  • There's nothing unsafe about string literal access if --noImplicitAny is turned on.

@adidahiya adidahiya merged commit d802bd7 into palantir:master Jun 5, 2017
@andy-hanson andy-hanson deleted the no-string-literal branch June 6, 2017 00:24
@renovate renovate bot mentioned this pull request Jun 6, 2017
Merged
@renovate renovate bot mentioned this pull request Jul 7, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajafff ajafff ajafff approved these changes

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-hanson @adidahiya @ajafff