-
Notifications
You must be signed in to change notification settings - Fork 889
Added prefer-readonly rule with fixes #2896
Commits on Jun 7, 2017
-
Added prefer-readonly rule with fixes
Deceptively simple... I look forward to contributors finding new and exciting test cases.
Josh Goldberg committedJun 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 267ad63 - Browse repository at this point
Copy the full SHA 267ad63View commit details -
Added member variable functions as test cases
Josh Goldberg committedJun 7, 2017 Configuration menu - View commit details
-
Copy full SHA for c88cdb2 - Browse repository at this point
Copy the full SHA c88cdb2View commit details -
Josh Goldberg committed
Jun 7, 2017 Configuration menu - View commit details
-
Copy full SHA for f7abbe0 - Browse repository at this point
Copy the full SHA f7abbe0View commit details -
Added prefer-readonly to tslint:all
Josh Goldberg committedJun 7, 2017 Configuration menu - View commit details
-
Copy full SHA for e37e2e3 - Browse repository at this point
Copy the full SHA e37e2e3View commit details -
Fixed internal source violations of prefer-readonly
Josh Goldberg committedJun 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 0c1fb66 - Browse repository at this point
Copy the full SHA 0c1fb66View commit details
Commits on Jun 9, 2017
-
Type checker and more intelligently handled class scope, corner cases
As suggested: * This now uses the type checker to see if types match * Keeps a stackable state for whether the scope is in a constructor (to deal with nested functions) * Adds a few more corner cases, such as parameter declarations, --/++ expressions, and overlapping classes The variable scoping logic was bleeding pretty heavily into the walker, so I moved it into its own class. Much clearer separation of concerns now.
Josh Goldberg committedJun 9, 2017 Configuration menu - View commit details
-
Copy full SHA for 2da094e - Browse repository at this point
Copy the full SHA 2da094eView commit details -
Josh Goldberg committed
Jun 9, 2017 Configuration menu - View commit details
-
Copy full SHA for efea6ec - Browse repository at this point
Copy the full SHA efea6ecView commit details -
Fixed parameter propertie by checking in handleConstructor
Also added a test for IIFEs used to set them.
Josh Goldberg committedJun 9, 2017 Configuration menu - View commit details
-
Copy full SHA for 569ac5a - Browse repository at this point
Copy the full SHA 569ac5aView commit details
Commits on Jun 12, 2017
-
Mostly addressed ajafff's feedback
* Split variableModifications into two Sets * Corrected computed property names * Corrected logic around constructor scope depths * Stopped recursing on nodes with declare keywords * ++/-- unary expressions only as modifiers
Josh Goldberg committedJun 12, 2017 Configuration menu - View commit details
-
Copy full SHA for f5fdb8e - Browse repository at this point
Copy the full SHA f5fdb8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42a336d - Browse repository at this point
Copy the full SHA 42a336dView commit details -
Fixed OUTSIDE_CONSTRUCTOR settings
Josh Goldberg committedJun 12, 2017 Configuration menu - View commit details
-
Copy full SHA for ae96afb - Browse repository at this point
Copy the full SHA ae96afbView commit details
Commits on Jun 13, 2017
-
Used utils.isFunctionScopeBoundary to better handle them
Also brought in tsutils@2.4.0. That should fix any caching shenanigans.
Josh Goldberg committedJun 13, 2017 Configuration menu - View commit details
-
Copy full SHA for a8ea477 - Browse repository at this point
Copy the full SHA a8ea477View commit details -
Cleaned ++/-- to be within property access checks
Josh Goldberg committedJun 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 69543a4 - Browse repository at this point
Copy the full SHA 69543a4View commit details
Commits on Jun 15, 2017
-
Merge branch 'master' of https://github.com/palantir/tslint into pref…
…er-readonly
Josh Goldberg committedJun 15, 2017 Configuration menu - View commit details
-
Copy full SHA for b68d4cf - Browse repository at this point
Copy the full SHA b68d4cfView commit details
Commits on Jun 18, 2017
-
Feedback: rationale, this.scope!, isModifier update
Josh Goldberg committedJun 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 4dd52ce - Browse repository at this point
Copy the full SHA 4dd52ceView commit details -
Josh Goldberg committed
Jun 18, 2017 Configuration menu - View commit details
-
Copy full SHA for b0c2b11 - Browse repository at this point
Copy the full SHA b0c2b11View commit details
Commits on Jun 19, 2017
-
Moved classScope and typeUtils, as per feedback
Josh Goldberg committedJun 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 1f2e78d - Browse repository at this point
Copy the full SHA 1f2e78dView commit details
Commits on Sep 12, 2017
-
Merge branch 'master' into prefer-readonly
# Conflicts: # package.json # src/language/walker/blockScopeAwareRuleWalker.ts
Josh Goldberg committedSep 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 946b52e - Browse repository at this point
Copy the full SHA 946b52eView commit details -
Josh Goldberg committed
Sep 12, 2017 Configuration menu - View commit details
-
Copy full SHA for a20e2c8 - Browse repository at this point
Copy the full SHA a20e2c8View commit details
Commits on Nov 4, 2017
-
Merge branch 'master' into prefer-readonly
# Conflicts: # src/language/rule/rule.ts # src/rules/noReferenceImportRule.ts
Josh Goldberg committedNov 4, 2017 Configuration menu - View commit details
-
Copy full SHA for fbdda51 - Browse repository at this point
Copy the full SHA fbdda51View commit details
Commits on Nov 5, 2017
-
Converted to applyWithFunction; added only-inline-lambdas option
Josh Goldberg committedNov 5, 2017 Configuration menu - View commit details
-
Copy full SHA for 8efa5bc - Browse repository at this point
Copy the full SHA 8efa5bcView commit details
Commits on Nov 24, 2017
-
Merge branch 'master' into prefer-readonly
# Conflicts: # src/rules/completedDocsRule.ts
Josh Goldberg committedNov 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 6918b76 - Browse repository at this point
Copy the full SHA 6918b76View commit details