This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
member-access: add fixer #2969
Merged
member-access: add fixer #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[new-fixer] `member-access` Fixes: #2967
src/rules/memberAccessRule.ts
Outdated
| @@ -118,18 +119,35 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| return; | |||
| } | |||
|
|
|||
| const isPublic = Lint.hasModifier(node.modifiers, ts.SyntaxKind.PublicKeyword); | |||
| let publicKeyword: ts.Node | undefined; | |||
There was a problem hiding this comment.
This feels like it could be separated into a tsutils function.
There was a problem hiding this comment.
👍
I added a getModifier utility to tsutils. I don't know if I release a new version this week though.
adidahiya
approved these changes
Aug 7, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[new-fixer]
member-accessFixes: #2967
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: