Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix #2986 await-promise accept intersection #2987

Merged

Conversation

yokomotod
Copy link
Contributor

PR checklist

Overview of change:

Rule await-promise accepts not only union type but intersection type.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @yokomotod! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can you please enable CircleCI on your fork to verify this change?

@yokomotod
Copy link
Contributor Author

@adidahiya @ajafff Thank you for your reviews.

sorry, I didn't notice that my build has been failed... It pass the test now!

@adidahiya adidahiya merged commit e22bf9e into palantir:master Jul 7, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants