This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Improve CLI error message when no files are specified #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @dupski! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
ajafff
reviewed
Jul 23, 2017
test/executable/executableTests.ts
Outdated
| assert.include(stderr, "Missing files", "stderr should contain notification about missing files"); | ||
| assert.include(stderr, | ||
| "No files specified. Use --project to lint a project folder.", | ||
| "stderr should contain notification about "); |
There was a problem hiding this comment.
this string looks truncated
There was a problem hiding this comment.
So it does, I'll check it out.
There was a problem hiding this comment.
I have corrected @ajafff, sorry about that!
ajafff
approved these changes
Jul 23, 2017
adidahiya
approved these changes
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The
tslintCLI now gives an unhelpfulMissing fileserror when you do not specify any files to lint or the --project argument.This PR improves the error message so future people won't have to google it like I did :)...
I have updated and run the tests.
CHANGELOG.md entry:
[enhancement] Improved CLI error message when no filenames are specified