This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
return-undefined: various bug fixes #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declared return type overrides contextual type
adidahiya
approved these changes
Oct 20, 2017
| @@ -93,11 +93,13 @@ export function someAncestor(node: ts.Node, predicate: (n: ts.Node) => boolean): | |||
| return predicate(node) || (node.parent !== undefined && someAncestor(node.parent, predicate)); | |||
| } | |||
|
|
|||
| export function ancestorWhere<T extends ts.Node>(node: ts.Node, predicate: (n: ts.Node) => boolean): ts.Node | undefined { | |||
| export function ancestorWhere<T extends ts.Node>(node: ts.Node, predicate: (n: ts.Node) => n is T): T | undefined; | |||
There was a problem hiding this comment.
nice, I like the type guard. do we still need the other non-type-guard function signature?
There was a problem hiding this comment.
I left it there to avoid breaking custom rules that might use this exported API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
return-undefinedfixed regressions: once again allows anything if return type isanyFixes: #2812
[bugfix]
return-undefineddeclared return type takes precedence over contextual type[bugfix]
return-undefinedhandles union return types in async functionsFixes: #3234
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: