Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Use CircleCi 2.0 #3490

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Use CircleCi 2.0 #3490

merged 2 commits into from
Nov 15, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Nov 15, 2017

Use CircleCI 2.0

Only build once and use the result to lint and test in separate jobs. That cuts the total time taken by CI in half.

We can now add an arbitrary amount of test jobs. I decided to stick with 4 for now:

  • node 4.8 with typescript@2.1
  • node 6.10 with typescript@2.4
  • node 8.x with typescript@stable (current version in yarn.lock)
  • node@latest (currently 9) with typescript@next

Test failures with typescript@next are fixed by #3488

[no-log]

@ajafff
Copy link
Contributor Author

ajafff commented Nov 15, 2017

This change also allows you to configure which CI jobs are required before merging PRs.
That means we can make testNext optional to avoid blocking PRs because of unrelated CI failures. Ref: #3485 (comment)

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 💯

@adidahiya
Copy link
Contributor

I will merge and you can fix any issues that show up on develop

That means we can make testNext optional to avoid blocking PRs because of unrelated CI failures.

this sounds like a good idea, feel free to make this change

@adidahiya adidahiya merged commit 53a864e into palantir:master Nov 15, 2017
@ajafff
Copy link
Contributor Author

ajafff commented Nov 16, 2017

@adidahiya

That means we can make testNext optional to avoid blocking PRs because of unrelated CI failures.

this sounds like a good idea, feel free to make this change

That's something you have to configure in the repo settings: https://circleci.com/docs/2.0/workflows-waiting-status/
disable: ci/circleci
enable: ci/circleci: build, ci/circleci: lint, ci/circleci: test, ci/circleci: test2.1, ci/circleci: test2.4

@ajafff ajafff deleted the circleci2 branch November 16, 2017 07:45
@adidahiya
Copy link
Contributor

@ajafff done

HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants