This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 889
Removed use of type checker from completed-docs #3557
Merged
adidahiya
merged 11 commits into
palantir:master
from
JoshuaKGoldberg:completed-docs-no-types
Feb 23, 2019
Merged
Removed use of type checker from completed-docs #3557
adidahiya
merged 11 commits into
palantir:master
from
JoshuaKGoldberg:completed-docs-no-types
Feb 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses tsutil's `getJsDoc` instead.
ajafff
suggested changes
Dec 6, 2017
ajafff
previously requested changes
Dec 12, 2017
|
3 tasks
whats the status of this PR? |
I think I've addressed all of @ajafff's feedback. It's been through a few merges. Also, some amusing errata: this also fixes the TS 2.8 issue with the |
Any recent updates on this? (Very eager to have back my completed-docs that hasn't worked since December 2016!) Would it be worth merging #3841 as a stopgap until this is completely ready to go? |
This was referenced Nov 4, 2018
johnwiseheart
approved these changes
Dec 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adidahiya
approved these changes
Feb 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses tsutil's
getJsDoc
instead.PR checklist
Overview of change:
Makes
completed-docs
an untyped rule by removing usages of the TSLint program. It instead usestsutils
'sgetJsDoc
.CHANGELOG.md entry:
[enhancement] Made completed-docs an untyped rule
[bugfix] Fixed single-line comment parsing for completed-docs