This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
feat(new-rule-option): improve strict-boolean-expressions
by adding allow-enum
#3604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added new configuration option "allow-enum", that disables errors when using enum in boolean expression, so that error wouldn't be emitted
Is there anything you'd like reviewers to focus on?
I've added the motivation and detailed description to the issue #3571 - take a look at that as well.
This PR addresses that issue using approach
b
described in that issue.CHANGELOG.md entry:
[new-rule-option]
strict-boolean-expressions
addsallow-enum
to allow using enums in boolean expressions