Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add the option allow-empty-functions in no-empty #3624

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

markvincze
Copy link
Contributor

PR checklist

Overview of change:

Introduces option to allow function declarations to be empty while using no-empty.

Is there anything you'd like reviewers to focus on?

This is my first PR to tslint, so any feedback is welcome.
I was a bit unsure if I did the correct setup for the options property (an array with an anyOf of the two strings).

CHANGELOG.md entry:

[enhancement] Introduces option to allow function declarations to be empty while using no-empty.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @markvincze! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@markvincze
Copy link
Contributor Author

I signed the CLA.

@ikokostya
Copy link

Any updates?

@markvincze
Copy link
Contributor Author

@ikokostya,
To me it seems that tslint is not actively maintained at the moment. PRs are piling up without getting reviews or getting merged.
I've tried to ping @tslint on Twitter too, but no response.

@johnwiseheart
Copy link
Contributor

Hello everyone- tslint has recently gotten some new maintainers - myself as one of them. Unfortunately it’s taking us a while to ramp up on everything and get through all the issues, but we’re starting to merge things in and try to bring tslint back to a stable state. Hold tight, we’ll get to this PR as soon as we can.

@markvincze
Copy link
Contributor Author

Hey @johnwiseheart, great news!

Copy link
Contributor

@suchanlee suchanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, thanks @markvincze!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants