Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[docs] additional code examples for 12 rules #3869

Merged
merged 24 commits into from
Jul 16, 2018
Merged

[docs] additional code examples for 12 rules #3869

merged 24 commits into from
Jul 16, 2018

Conversation

Shinigami92
Copy link
Contributor

PR checklist

Overview of change:

Added code examples to rules:

  • noAny
  • noEmptyInterface
  • noSparseArrays
  • noUnnecessaryCallbackWrapper
  • objectLiteralSortKeys
  • oneVariablePerDeclaration
  • onlyArrowFunctions
  • preferTemplate
  • radix
  • switchDefault
  • typedef
  • useIsnan

CHANGELOG.md entry:

See: "Overview of change"

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @Shinigami92! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented May 3, 2018

@palantitrech Sorry, but currently I am not allowed to sign the CLA.
I want to and will do this in the next few days / weeks.
Currently, the organization I work for joins an OSB alliance and I have to wait :/

After signing the CLA, I am very interested in supporting this project even more!

@suchanlee
Copy link
Contributor

@Shinigami92 is the CLA signed? would love to merge this!

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented May 30, 2018

@suchanlee sorry but I want this too and also work on tslint
But I have to wait at my business :(
My boss said that it is in final stage and i'm hoping and praying that it's next week
This week i'm in holiday

@suchanlee
Copy link
Contributor

ah okay sounds good, just let us know!

@Shinigami92
Copy link
Contributor Author

Finally I could accept the CLA

@Shinigami92
Copy link
Contributor Author

AFAICT everything is now ready for review and merge.
Shall I change the dates in each src/rules/code-examples/* on line 3 or are they good as is?

@johnwiseheart
Copy link
Contributor

Hi! Sorry that this has been left for a while. Please update the dates of the copyrights, and then we can merge this in.

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented Jul 12, 2018

I think in src/rules/classNameRule.ts an import line was added
that caused the conflict

For now I dont have time anymore, I can look into it in maybe 10h

@Shinigami92
Copy link
Contributor Author

@johnwiseheart anything needed before review?

@johnwiseheart
Copy link
Contributor

Looks good to me. Can you confirm whether you have signed the CLA? The cla bot seems to be a little funky right now.

@Shinigami92
Copy link
Contributor Author

yes I have

@johnwiseheart
Copy link
Contributor

Sweet, let me look into why its not reporting properly and I'll merge it in once it passes.

@Shinigami92
Copy link
Contributor Author

yay it passed

@johnwiseheart johnwiseheart merged commit 0e8f9e0 into palantir:master Jul 16, 2018
@johnwiseheart
Copy link
Contributor

Thanks for your contribution!

@Shinigami92
Copy link
Contributor Author

I will look into some more code examples in the next few days
and then do this in a new pr

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants