-
Notifications
You must be signed in to change notification settings - Fork 888
[docs] additional code examples for 12 rules #3869
[docs] additional code examples for 12 rules #3869
Conversation
…per and object-literal-sort-keys
Accidentally committed formatting that VSCode did, has nothing to do with the commit
fixed vscode's formatting
…into docs/code-examples
Thanks for your interest in palantir/tslint, @Shinigami92! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
@palantitrech Sorry, but currently I am not allowed to sign the CLA. After signing the CLA, I am very interested in supporting this project even more! |
@Shinigami92 is the CLA signed? would love to merge this! |
@suchanlee sorry but I want this too and also work on tslint |
ah okay sounds good, just let us know! |
Finally I could accept the CLA |
AFAICT everything is now ready for review and merge. |
Hi! Sorry that this has been left for a while. Please update the dates of the copyrights, and then we can merge this in. |
The GitHub GUI is a bit confusing
I think in For now I dont have time anymore, I can look into it in maybe 10h |
@johnwiseheart anything needed before review? |
Looks good to me. Can you confirm whether you have signed the CLA? The cla bot seems to be a little funky right now. |
yes I have |
Sweet, let me look into why its not reporting properly and I'll merge it in once it passes. |
yay it passed |
Thanks for your contribution! |
I will look into some more code examples in the next few days |
PR checklist
Overview of change:
Added code examples to rules:
CHANGELOG.md entry:
See: "Overview of change"