This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
bugfix - no-use-before-declare - exception for destructuring w/ rename #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchanlee
reviewed
May 7, 2018
| @@ -68,7 +74,8 @@ export { | |||
| }; | |||
|
|
|||
| var undeclaredA = 42; | |||
| let { undeclaredB } = { undeclaredB: 43 }; | |||
| var { undeclaredB } = { undeclaredB: 43 }; | |||
| var { undeclaredB: undeclaredA } = { undeclaredB: 43 }; | |||
| const [ undeclaredC, [undeclaredD] ] = [ 1, [2] ]; | |||
|
|
|||
There was a problem hiding this comment.
Can we add test cases for multiple reassignments and reassignment and non-reassignment in the same destructuring?
giladgray
approved these changes
May 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The rule checks that identifiers have a declaration with a
pos<= to the referencepos, which isn't the case when destructuring w/ a rename.Is there anything you'd like reviewers to focus on?
Any edge cases with the destructuring syntax that would require additional tests?
CHANGELOG.md entry:
[bugfix]
no-use-before-declareFixes false positives when using the destructuring syntax (#3761)