Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-magic-numbers - support for negative zero #3903

Merged
merged 1 commit into from
May 30, 2018
Merged

no-magic-numbers - support for negative zero #3903

merged 1 commit into from
May 30, 2018

Conversation

aervin
Copy link
Contributor

@aervin aervin commented May 11, 2018

PR checklist

Overview of change:

The rule's allowed-numbers were mapped using theString constructor, which strips the - off of -0. Using Object.is because 0 === -0 in JS.

giladgray
giladgray approved these changes May 17, 2018
View reviewed changes
Copy link

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@suchanlee suchanlee merged commit 0bc48cd into palantir:master May 30, 2018
@giladgray giladgray mentioned this pull request Jul 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aervin @giladgray @suchanlee