Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[bugfix] member-ordering includes getters and setters #3984

Merged
merged 10 commits into from
Oct 5, 2019
Merged

[bugfix] member-ordering includes getters and setters #3984

merged 10 commits into from
Oct 5, 2019

Commits on Aug 24, 2018

  1. Added "public-static-accessor" and others to correctly handle getters… 

    … and setters.

Added getters/setters to member-ordering/alphabetize/test.ts.lint
    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    f5ebd18 View commit details
    Browse the repository at this point in the history

  2. tslint.json: use preset "fields-first" for member-ordering rule inste… 

    …ad of previous old-style config.

This seems to match previous config most closely, requiring only 5 changes.
    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    090fb72 View commit details
    Browse the repository at this point in the history

  3. Fix switched private/public.

    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    574b2f5 View commit details
    Browse the repository at this point in the history

  4. Handle get/set order properly.

    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    33c7656 View commit details
    Browse the repository at this point in the history

  5. Output warning that old-style options do not handle getters.

    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    79cdb39 View commit details
    Browse the repository at this point in the history

  6. Don't use localeCompare to avoid different orders depending on system… 

    … locale/node config.
    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    4d7e6ef View commit details
    Browse the repository at this point in the history

  7. Simplify checker slightly.

    @NaridaL
    NaridaL committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    2ba99db View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. Merge branch 'master'

    Josh Goldberg committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b88e57e View commit details
    Browse the repository at this point in the history

  2. Re-ran prettier on memberOrderingRule.ts

    Josh Goldberg committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    fa8f31b View commit details
    Browse the repository at this point in the history

  3. ...but with the right Prettier version

    Josh Goldberg committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    0eb988c View commit details
    Browse the repository at this point in the history