This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Use Buffer.allocUnsafe instead of the deprecated new Buffer() #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(node:16148) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. allocUnsafe should be fine because in both cases, the buffer is immediately filled and thrown out.
giladgray
reviewed
Jun 26, 2018
| @@ -66,7 +66,7 @@ function showEncoding(encoding: Encoding): string { | |||
| function detectEncoding(fileName: string): Encoding { | |||
| const fd = fs.openSync(fileName, "r"); | |||
| const maxBytesRead = 3; // Only need 3 bytes to detect the encoding. | |||
| const buffer = new Buffer(maxBytesRead); | |||
| const buffer = Buffer.allocUnsafe(maxBytesRead); | |||
There was a problem hiding this comment.
@NaridaL is there a not "unsafe" alternative? i'm not familiar with these internals.
In both cases, the buffer is immediately initialized with file contents, nothing is output to the user, and I'm not currently seeing any situation where tslint has access to sensitive data the user doesn't have access to anyway. allocUnsafe should be fine. |
pablobirukov
pushed a commit
to evolution-gaming/tslint
that referenced
this pull request
Jul 4, 2018
…ir#3985) (node:16148) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. allocUnsafe should be fine because in both cases, the buffer is immediately filled and thrown out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(node:16148) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
allocUnsafe should be fine because in both cases, the buffer is immediately filled and thrown out.
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: