Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[new-rule] add comment-type rule #4008

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

michaelblack
Copy link
Contributor

@michaelblack michaelblack commented Jul 3, 2018

PR checklist

Overview of change:

Adds a new rule comment-type which allows you to specify the type of comments you allow in your project.

CHANGELOG.md entry:

[new-rule] comment-type

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @michaelblack! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@michaelblack michaelblack changed the title Add comment-type rule [new-rule] add comment-type rule Jul 5, 2018
@johnwiseheart
Copy link
Contributor

Hi there, I think the tests have been fixed in master. Can you please merge to check that they pass?

Thanks

@michaelblack
Copy link
Contributor Author

michaelblack commented Jul 12, 2018

@johnwiseheart
I rebased off master, all tests are passing now.

@michaelblack
Copy link
Contributor Author

@johnwiseheart Anything else I can do for this?

@johnwiseheart
Copy link
Contributor

Sorry I missed this earlier: can you add your rule to this list: https://github.com/palantir/tslint/blob/master/src/configs/all.ts

@michaelblack
Copy link
Contributor Author

It is added there, though it's the most permissive case allowing all comment types to be present.

Copy link
Contributor

@johnwiseheart johnwiseheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh my mistake. Looks good to me

@johnwiseheart johnwiseheart merged commit 1a0fe45 into palantir:master Jul 27, 2018
@johnwiseheart
Copy link
Contributor

Thanks for contributing!

@giladgray giladgray mentioned this pull request Aug 8, 2018
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants