This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix CI: no-implicit-dependencies test failure; typescript@next failure #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobirukov
force-pushed
the
fix-ci-after-no-implicit-dependencies
branch
2 times, most recently
from
7ef96b7
to
4c4e6a0
Compare
pablobirukov
force-pushed
the
fix-ci-after-no-implicit-dependencies
branch
from
09782f1
to
cfe7e0a
Compare
pablobirukov
changed the title
johnwiseheart
approved these changes
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build status:
Failing tests on
mastercaused by consequent merges of #3979 and #3875.whitelist-with-devwith option"dev": the rule looks at bothdevandpeerdependencies, thus allowingtypescriptpackage to be used.As it turned out, there is another PR fixing this (#4011)
Failing
testNextstep caused by removedunescapeIdentifier()(microsoft/TypeScript#25333)Changes overview:
noStringLiteralRule.tstsutils(fixed in 2.27.2, version bumped)tsutils@2.27.2relies on typescript@2.9.x (version bumped)noUnsafeAnyRule.tsdue to updated typings