This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[new-rule] no-default-import #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobirukov
force-pushed
the
no-default-import
branch
from
68f5110
to
ac8079f
Compare
|
@R00GER, can you please fix the tests by adding your rule to |
pablobirukov
force-pushed
the
no-default-import
branch
from
ac8079f
to
98f7158
Compare
johnwiseheart
previously requested changes
Sep 3, 2018
There was a problem hiding this comment.
Hi @R00GER, can you please rephrase the rationale here to explain the use of the rule a little better - I think we can probably improve the wording of the example.
Once thats done, please ping me and I'll merge.
|
@johnwiseheart, please take a look at another attempt |
|
Hi @johnwiseheart, any chance to have this merged? |
ericanderson
dismissed
johnwiseheart’s stale review
Author did as requested.
ericanderson
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of change:
As the
no-default-export, the rule supposed to reduce usage of default imports/exports.New rule supposed to narrow the scope of your changes in the case of medium-sized (and bigger) projects. Say, you have 20 packages and every removed default export from utility package would lead to changes in each package, which might be harder to get merged by various reasons (harder to get your code approved due to a number of required reviewers; longer build time due to a number of affected packages). That's why "requires too many changes elsewhere" is a reason why I see
no-default-exportignored so often.Unlike
no-default-export, the rule requires you to make changes only in the package you work on and the package you import from (unless the member you try to import already exported as a named one).It has a config option where you have to specify a regexp for packages you own, imports from which are to be checked. By default it checks relative imports, presuming, you own these files.
CHANGELOG.md entry:
[new-rule]
no-default-import