-
Notifications
You must be signed in to change notification settings - Fork 889
[new-rule] add whitespace rule for open braces #4068
Conversation
Thanks for your interest in palantir/tslint, @erikseulean! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Where can I read the CLA document? I cannot find it. |
Hi @erikseulean, please see https://cla.palantir.com/, thanks! |
@jkillian I cannot find any terms there, it's only an authorization link for individual contributors but nothing rearding the content of the CLA. |
Hi @erikseulean, turns out you have to authorize Github first before you can see the document. Obviously this isn't ideal, so I've pasted some screenshots of the document below so you can see it ahead of time: |
Hi @jkillian thanks for this. I signed the CLA. |
ping @jkillian Anybody up to look over this? |
@johnwiseheart do you think this brings some value to the existing codebase ? I'm happy to have this closed in case you don't consider it valuable to remove the clutter of long standing PRs. |
I think this added feature is worth having - does your addition also work with |
Hmm, not sure I understand exactly what test you want me to add. Could you please point me to a similar example ? I have already added a test, and a test fix, is it something else you asked me about or you missed those ? |
My mistake - I missed your |
When will this be published @johnwiseheart? |
I will try and make a new release next week.
…On Mon, 10 Dec 2018 at 14:02, James Monger ***@***.***> wrote:
When will this be published @johnwiseheart
<https://github.com/johnwiseheart>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4068 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEEo1ANZMb5K_p2pzeARXHA2z_gNHE6iks5u3mlrgaJpZM4Vgz6e>
.
|
PR checklist
Overview of change:
Implements a whitespace option
check-postbrace
that is checking for a space, new line or tab after an open curly brace.