Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

"< 0" means less than zero, not greater than #4183

Merged
merged 1 commit into from
Nov 6, 2018
Merged

"< 0" means less than zero, not greater than #4183

merged 1 commit into from
Nov 6, 2018

Conversation

samuela
Copy link
Contributor

@samuela samuela commented Sep 23, 2018

No description provided.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @samuela! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@samuela
Copy link
Contributor Author

samuela commented Oct 1, 2018

I've signed the CLA, but it doesn't seem like the @palantirtech bot has updated the PR.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks for this @samuela!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 191f5e4 into palantir:master Nov 6, 2018
@samuela samuela deleted the patch-1 branch November 6, 2018 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuela @palantirtech @JoshuaKGoldberg