allow whitelisted modules to start with @ symbol

[ifiokjr]

PR checklist

• Addresses an existing issue: no-implicit-dependencies: Support path mapping #3364
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

For the rule no-implicit-dependencies an array of whitelisted modules can be added. However, this didn't work when trying to whitelist a module that started with an @ symbol.

This is important since projects with custom paths in their compiler options can now use this lint configuration option without the false positives.

With this change, the rule can be used as follows.

"no-implicit-dependencies": [true, ["@components", "@app"]]

CHANGELOG.md entry:

[bugfix]

[palantirtech]

Thanks for your interest in palantir/tslint, @ifiokjr! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[ifiokjr]

How do I get this reviewed and merged?

[nicogreenarry]

Looks like maybe you still need to sign the contributor license agreement? I'm just guessing, since I don't see an update from the palbot.

[ifiokjr]

@nicogreenarry I had signed pretty early on.

[elSuperRiton]

+1 for this feature. Prefixing modules with ‘@‘ is a fairly common thing to do.

[FernandoEsparrinha]

This would be really helpful. Any updates ?

[Merott]

I'd also like to see this merged. However, there are code formatting changes in this PR that shouldn't be there. @ifiokjr, perhaps correcting those will speed up the process?

[ifiokjr]

@Merott The formatting was caused by a prettier pre-commit rule referenced in the package.json

tslint/package.json

Lines 32 to 34 in 61b0826

	"precommit": "npm-run-all precommit:prettier",
	"precommit:prettier": "pretty-quick --staged",
	"prettier": "prettier --write ./**/*.{js,ts,css,scss,json,md,yml} --ignore-path ./.prettierignore",

	"precommit": "npm-run-all precommit:prettier",
    "precommit:prettier": "pretty-quick --staged",
    "prettier": "prettier --write ./**/*.{js,ts,css,scss,json,md,yml} --ignore-path ./.prettierignore",

I've resubmitted the changes now after running git commit --no-verify.

[elyalvarado]

@ajafff this is a very common pattern in react-native repos to avoid a lot of relative traversal ../../../../. This PR is very simple and includes tests, can you guys take a look at it?

[ifiokjr]

Thanks for the approval @JoshuaKGoldberg 👍
@ajafff Any chance it could be merged?

[ericanderson]

Sorry about the delays.