This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add support for unknown to array-type rule. #4219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Currently, when used with TS 3.0, the
array-simple
rule will error onunknown[]
, instead enforcing that it should be written asArray<unknown>
. A small change was needed forunknown
to be considered a simple type with TS 3.0.Backwards and forwards compatibility
This change works with both Typescript 2.x and 3.x.
The tests are backwards compatible with TS 2.x, because in
unknown
is already treated as a simple type, in that case. (It's treated as a non-generic type reference)The implementation is backwards compatible with TS 2.x, because
ts.SyntaxKind.UnknownKeyword:
will evaluate toundefined:
and so that case of the switch statement will just never match withnodeType.kind
, which should never be undefined.CHANGELOG.md entry:
[enhancement]
array-type
rule handles Typescript 3.0's unknown type properly