This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
prefer-object-spread: this is new to ES2018, not ES2015 #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for spread properties in object literals wasn't added until ES2018, not ES2015. The proposal is here: https://github.com/tc39/proposal-object-rest-spread And MDN documents it as such too: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#Spread_in_object_literals
|
Thanks for your interest in palantir/tslint, @vapier! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
approved these changes
Nov 28, 2018
JoshuaKGoldberg
added
the
PR: waiting for CLA
|
i've signed the CLA now. had to check with my company first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for spread properties in object literals wasn't added until
ES2018, not ES2015. The proposal is here:
https://github.com/tc39/proposal-object-rest-spread
And MDN documents it as such too:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#Spread_in_object_literals