Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Show offending value in 'no-magic-numbers' error message #4332

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

dariobanfi
Copy link
Contributor

PR checklist

Overview of change:

I just fixed an issue about showing the offending value for no-magic-numbers rule.

Before:

'magic numbers' are not allowed

Now:

'magic numbers' are not allowed: 3

CHANGELOG.md entry:

I didn't create one for such a small thing. Should I?

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @dariobanfi! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @dariobanfi!

Changelog entry

You should get credit for this! 😊

Let's say something like:

[enhancement] Added failing number to the magic-numbers rule

@JoshuaKGoldberg JoshuaKGoldberg merged commit 19b359e into palantir:master Dec 2, 2018
@JoshuaKGoldberg JoshuaKGoldberg modified the milestone: TSLint 6.0 Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants