This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix [ordered-imports] "import-sources-order": any invalidate "grouped-imports"
#4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
approved these changes
Dec 12, 2018
ericanderson
added a commit
that referenced
this pull request
Dec 12, 2018
ericanderson
added a commit
that referenced
this pull request
Dec 12, 2018
abierbaum
added a commit
to abierbaum/tslint
that referenced
this pull request
Jan 16, 2019
This change updates the refactored "group" based orderedImports code to handle the cases fixed in the following previous PRs: - palantir#4374: fixed grouping for import-sources-order - palantir#3733: check all imports of same type are grouped As part of this we removed the concept of ImportType as this is now covered by the defined groups for sorting. Moved the check for ensuring groups are not standing alone into the code checkBlocksGroup() code where other group checks are done. Ex: ``` import './baa'; import './baz'; import './caa'; // this should fail ``` Also had to update several other test cases to include the failure notice about import groups needing to be together.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
"import-sources-order": anyinvalidate "grouped-imports" #4338Overview of change:
Fixed bug where
ImportsBlockalways had theImportTypeset toLIBRARY_IMPORTwhen theimport-sources-orderrule is set toany.Is there anything you'd like reviewers to focus on?
I recommend toggling
Hide Whitespace Changesso that the diff ofgetImportTypeis cleaner and clearer.Moved
getImportTypeoutside ofImportsBlockclass. Only referenced in one location as a helper function, and has no dependency on the state of anImportsBlock, so it seems okay to separate it out. Could also make it apublic staticmethod and keep it inside the class, if so desired. Open to other suggestions!CHANGELOG.md entry:
[bugfix][
import-sources-order] Settingimport-sources-order: anyno longer invalidatesgrouped-imports: true