This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix behavior of jsRules:true to include explicitly disabled rules. #4517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Changed behavior of
jsRules:true
to copy over ALL rule configurations that are compatible with JS, including any that are explicitly disabled.Is there anything you'd like reviewers to focus on?
The original PR (#3641) that added
jsRules:true
functionality seemed to make a point to describe its desired/implemented behavior to copy over all "active" rules that are valid for JS. Does the term "active" mean something special that is not simply "those that are not disabled"? Is there still some kind of rule configurations that I should be skipping over?CHANGELOG.md entry:
[bugfix] Explicit disabling of rules is now copied over to jsRules when using jsRules:true