Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Docs: add note to docs about zero-indexing for machine formatters #4544

Conversation

theoretick
Copy link
Contributor

@theoretick theoretick commented Feb 25, 2019

PR checklist

Overview of change:

Add note to docs clarifying positioning as zero-indexed for machine formatters

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

cc @JoshuaKGoldberg

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @theoretick! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few grammar suggestions...

docs/formatters/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks @theoretick!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear documentation: line position off by 1 when using JSON formatter
3 participants