Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add junit output for files which are successfully linted. #4566

Merged
merged 5 commits into from
Mar 10, 2019
Merged

Add junit output for files which are successfully linted. #4566

merged 5 commits into from
Mar 10, 2019

Conversation

darrena092
Copy link
Contributor

@darrena092 darrena092 commented Mar 5, 2019

PR checklist

Overview of change:

This fixes an issue with the junit formatter. Successful test cases are now output when files are linted without error.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @darrena092! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@darrena092 darrena092 changed the title WIP Add junit output for files which are successfully linted. Add junit output for files which are successfully linted. Mar 5, 2019
@darrena092
Copy link
Contributor Author

Just another note on this. It has been successfully tested with Jenkins, and it works great.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Some performance concerns, but generally the result looks great.

src/formatters/junitFormatter.ts Outdated Show resolved Hide resolved
test/formatters/junitFormatterTests.ts Show resolved Hide resolved
Darren Anderson added 2 commits March 7, 2019 09:50
…xture of files which lint successfully and files which contain errors.
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! 🙌

src/formatters/junitFormatter.ts Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Junit formatter prevents Jenkins picking up results on success
4 participants