Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Include actual types for restrict-plus-operands. #4635

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Include actual types for restrict-plus-operands. #4635

merged 4 commits into from
Apr 16, 2019

Commits on Apr 7, 2019

  1. Include actual types for restrict-plus-operands. 

    It can be difficult for users to find out why exactly they received the
"restrict-plus-operands" lint error. In particular, users often end up
with `any` types leaking into their code (e.g. in tests), and are then
puzzled why this triggers.

To fix, this change includes a textual representation of the type in the
error message, e.g.:

    [Operands of '+' operation must either be both strings or both numbers, but found 5 + undefined[]]

The type representation isn't always super pretty (e.g. the
`undefined[]` bit above), but should still be helpful, and also matches
TS compiler's representation of these.
    @mprobst
    mprobst committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    00b4a5d View commit details
    Browse the repository at this point in the history

  2. Special case emitting undefined[] for empty arrays.

    @mprobst
    mprobst committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    9054ba1 View commit details
    Browse the repository at this point in the history

  3. Trivial change to kickstart CircleCI

    Josh Goldberg authored Apr 7, 2019
    Configuration menu
    Copy the full SHA
    1a169ae View commit details
    Browse the repository at this point in the history

  4. Revert "Trivial change to kickstart CircleCI"

    Josh Goldberg authored Apr 7, 2019
    Configuration menu
    Copy the full SHA
    8e30602 View commit details
    Browse the repository at this point in the history