This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Remove unnecessary break in switchDefault example #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last switch case does not need a break statement as it is already the switch will already end after it. This way this example will also ensure following the rule switchFinalBreakRule.
|
Thanks for your interest in palantir/tslint, @rarenal! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
approved these changes
Apr 13, 2019
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Last switch case does not need a break statement as the switch will already end after it. This way this example will also ensure following the rule switchFinalBreakRule which it does not at the moment.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[documentation] Fix code example for
switch-defaultrule