This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 889
Fixes "no-redundant-jsdoc" exception on this tag #4690
Merged
adidahiya
merged 1 commit into
palantir:master
from
bugsduggan:fix-no-redundant-jsdoc-error
May 15, 2019
Merged
Fixes "no-redundant-jsdoc" exception on this tag #4690
adidahiya
merged 1 commit into
palantir:master
from
bugsduggan:fix-no-redundant-jsdoc-error
May 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your interest in palantir/tslint, @bugsduggan! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
previously requested changes
May 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems nice and clean (thanks!); just waiting on a corresponding test.
``` The 'no-redundant-jsdoc' rule threw an error in 'some-file.ts': Error: Unexpected tag kind: JSDocThisTag ``` This appears to be similar to palantir#3413
bugsduggan
force-pushed
the
fix-no-redundant-jsdoc-error
branch
from
May 7, 2019 06:36
aa3e31c
to
57a52a2
Compare
adidahiya
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bugsduggan
Merged
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be similar to #3413
PR checklist
Overview of change:
Adds
JSDocThisTag
to the redundant cases.Is there anything you'd like reviewers to focus on?
I appreciate this is my first contribution to this project so feel free to point me in the direction of any contribution guidelines that I've overlooked.
CHANGELOG.md entry:
[bugfix]
no-redundant-jsdoc
no longer errors onJSDocThisTag