Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-async-without-await: check type property and add tests #4782

Merged
merged 1 commit into from
Jul 4, 2019
Merged

no-async-without-await: check type property and add tests #4782

merged 1 commit into from
Jul 4, 2019

Conversation

tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented Jul 2, 2019 •
edited by JoshuaKGoldberg
Loading

PR checklist

Overview of change:

Check for if node.type property exists when node.body is undefined

@JoshuaKGoldberg JoshuaKGoldberg changed the title check type property and add tests no-async-without-await: check type property and add tests Jul 4, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for the bugfix and excellent tests @tanmoyopenroot! 🙌✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8056e63 into palantir:master Jul 4, 2019
@adidahiya adidahiya mentioned this pull request Aug 20, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2020
Merged
This was referenced Mar 18, 2020
Closed
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@PropTekCTO PropTekCTO mentioned this pull request May 31, 2024
Open
@christian-thiel-webcom christian-thiel-webcom mentioned this pull request Aug 10, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[False positive] no-async-without-await and abstract methods
2 participants
@tanmoyopenroot @JoshuaKGoldberg