Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix strict comparison false positive #4786

Conversation

tanmoyopenroot
Copy link
Contributor

PR checklist

Overview of change:

check if rightType or leftType in Binary Expression contains null or undefined.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @tanmoyopenroot! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1e48ae7 into palantir:master Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strict-comparison false positive (TSLint 5.18.0)
2 participants